Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3498: Adding Clanner Tracking to MegaMek #3500

Closed
wants to merge 1 commit into from
Closed

3498: Adding Clanner Tracking to MegaMek #3500

wants to merge 1 commit into from

Conversation

Windchild292
Copy link
Contributor

This handles the bug raised in #3498, namely that any melee attacks are based on the 'Mech's tech base and not the pilot / commander's status.

@Windchild292 Windchild292 self-assigned this Mar 8, 2022
@Windchild292 Windchild292 mentioned this pull request Mar 8, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #3500 (e931336) into master (3140012) will decrease coverage by 0.00%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3500      +/-   ##
============================================
- Coverage     22.67%   22.67%   -0.01%     
- Complexity     4770     4771       +1     
============================================
  Files          2081     2081              
  Lines        243767   243777      +10     
  Branches      45591    45596       +5     
============================================
+ Hits          55265    55267       +2     
- Misses       187013   187021       +8     
  Partials       1489     1489
Impacted Files Coverage Δ
megamek/src/megamek/client/bot/MoveOption.java 0.00% <0.00%> (ø)
...c/megamek/client/bot/princess/BasicPathRanker.java 59.96% <0.00%> (-0.08%) ⬇️
.../megamek/client/generator/RandomNameGenerator.java 0.00% <0.00%> (ø)
...erator/skillGenerators/AbstractSkillGenerator.java 31.57% <0.00%> (-0.86%) ⬇️
...erator/skillGenerators/ConstantSkillGenerator.java 0.00% <ø> (ø)
...killGenerators/ModifiedConstantSkillGenerator.java 0.00% <0.00%> (ø)
...Generators/ModifiedTotalWarfareSkillGenerator.java 14.28% <0.00%> (ø)
...nerator/skillGenerators/TaharqaSkillGenerator.java 0.00% <0.00%> (ø)
...or/skillGenerators/TotalWarfareSkillGenerator.java 7.14% <0.00%> (ø)
...rc/megamek/client/ratgenerator/CrewDescriptor.java 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3140012...e931336. Read the comment docs.

HammerGS
HammerGS requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@HammerGS HammerGS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawn.

HammerGS
HammerGS reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawn

@HammerGS
Copy link
Member

Based on the conversations on Discord. Please adjust the wording of any player facing text to "Clan Pilot". While the preference is to not have any reference in the code to the term "Clanner" that can stand.

@HammerGS HammerGS added the In Development (Draft) An additional way to mark something as a draft. Make it stand out more. label May 20, 2023
@kernhe
Copy link

kernhe commented Jul 29, 2023

How can I help here?

@SJuliez SJuliez mentioned this pull request Feb 14, 2024
Merged
@SJuliez
Copy link
Member

SJuliez commented Feb 14, 2024

Replaced by #5166

@SJuliez SJuliez closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammerGS HammerGS HammerGS requested changes

Assignees

@Windchild292 Windchild292

Labels
Bug In Development (Draft) An additional way to mark something as a draft. Make it stand out more.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Windchild292 @HammerGS @kernhe @SJuliez